From 0f2bf32b79f2a90ad40f3b28bec385524ccfe621 Mon Sep 17 00:00:00 2001
From: Maix0 <maix522@gmail.com>
Date: Wed, 10 Jul 2024 21:43:47 +0200
Subject: [PATCH] Remove readline

---
 Minishell.mk                       |  4 ++--
 flake.nix                          |  4 +---
 includes/app/signal_handler.h      |  4 +---
 includes/minishell.h               |  8 +-------
 valgrind_readline_leaks_ignore.txt | 12 ------------
 5 files changed, 5 insertions(+), 27 deletions(-)
 delete mode 100644 valgrind_readline_leaks_ignore.txt

diff --git a/Minishell.mk b/Minishell.mk
index c1b0ba81..950d2fc8 100644
--- a/Minishell.mk
+++ b/Minishell.mk
@@ -6,7 +6,7 @@
 #    By: maiboyer <maiboyer@student.42.fr>          +#+  +:+       +#+         #
 #                                                 +#+#+#+#+#+   +#+            #
 #    Created: 2024/04/28 17:28:30 by maiboyer          #+#    #+#              #
-#    Updated: 2024/07/05 18:00:14 by maiboyer         ###   ########.fr        #
+#    Updated: 2024/07/10 21:02:49 by maiboyer         ###   ########.fr        #
 #                                                                              #
 # **************************************************************************** #
 
@@ -19,7 +19,7 @@ link_group = -Wl,--start-group $(1) -Wl,--end-group
 BUILD_DIR ?= $(shell realpath ./build/)
 
 # Flags
-CFLAGS 	= -Werror -Wextra -Wall -Wno-unused-command-line-argument -g3 -MMD -lreadline  -I./includes -I./output/include -I./stdme/output/include -rdynamic -Wl,-E
+CFLAGS 	= -Werror -Wextra -Wall -Wno-unused-command-line-argument -g3 -MMD  -I./includes -I./output/include -I./stdme/output/include -rdynamic -Wl,-E
 # CFLAGS += -fsanitize=address -fno-omit-frame-pointer -fsanitize-address-use-after-return=runtime -fno-common -fsanitize-address-use-after-scope
 # Sources
 # LIB =	./libft/ft_bzero.c \
diff --git a/flake.nix b/flake.nix
index f03e1b66..36e8d65b 100644
--- a/flake.nix
+++ b/flake.nix
@@ -36,14 +36,12 @@
             valgrind.dev
             valgrind
             gnumake
-            readline.out
-            readline.dev
             generic_c.packages.${system}.default
             c_formatter_42.packages.${system}.default
             llvmPackages.bintools
             norminette
             rust-bin.stable.latest.default
-            (tree-sitter.override {webUISupport = true;})
+            #(tree-sitter.override {webUISupport = true;})
             nodejs
           ];
           VALGRIND_INC_OPT = "${pkgs.valgrind.dev}/include";
diff --git a/includes/app/signal_handler.h b/includes/app/signal_handler.h
index c5455f06..533ed4fb 100644
--- a/includes/app/signal_handler.h
+++ b/includes/app/signal_handler.h
@@ -6,7 +6,7 @@
 /*   By: maiboyer <maiboyer@student.42.fr>          +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2024/05/02 13:20:25 by maiboyer          #+#    #+#             */
-/*   Updated: 2024/05/08 21:52:34 by maiboyer         ###   ########.fr       */
+/*   Updated: 2024/07/10 21:03:38 by maiboyer         ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -17,8 +17,6 @@
 #include <signal.h>
 #include <stdio.h>
 
-#include <readline/readline.h>
-
 typedef t_i32 t_signal;
 
 t_error install_signal(void);
diff --git a/includes/minishell.h b/includes/minishell.h
index af08e076..5095437c 100644
--- a/includes/minishell.h
+++ b/includes/minishell.h
@@ -6,7 +6,7 @@
 /*   By: rparodi <rparodi@student.42.fr>            +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2024/03/28 14:41:15 by rparodi           #+#    #+#             */
-/*   Updated: 2024/05/09 16:28:26 by rparodi          ###   ########.fr       */
+/*   Updated: 2024/07/10 21:02:59 by maiboyer         ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -18,12 +18,6 @@
 #include "me/types.h"
 
 #include <fcntl.h>
-#include <stdio.h>
-#include <readline/history.h>
-#include <readline/readline.h>
-#include <stdarg.h>
-#include <stdlib.h>
-#include <string.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <unistd.h>
diff --git a/valgrind_readline_leaks_ignore.txt b/valgrind_readline_leaks_ignore.txt
deleted file mode 100644
index cef55ae4..00000000
--- a/valgrind_readline_leaks_ignore.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-{
-	leak readline
-	Memcheck:Leak
-	...
-	fun:readline
-}
-{
-	leak add_history
-	Memcheck:Leak
-	...
-	fun:add_history
-}
\ No newline at end of file